[
https://issues.apache.org/jira/browse/BEAM-6838?focusedWorklogId=216457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216457
]
ASF GitHub Bot logged work on BEAM-6838:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/19 20:47
Start Date: 20/Mar/19 20:47
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8064: [BEAM-6838]
Go SDK: Improving error msgs in pipeline serialization.
URL: https://github.com/apache/beam/pull/8064#discussion_r267529336
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/serialize.go
##########
@@ -145,20 +145,20 @@ func encodeCustomCoder(c *coder.CustomCoder)
(*v1.CustomCoder, error) {
func decodeCustomCoder(c *v1.CustomCoder) (*coder.CustomCoder, error) {
t, err := decodeType(c.Type)
if err != nil {
- return nil, fmt.Errorf("decodeCustomCoder bad type: %v", err)
+ return nil, fmt.Errorf("failed to decode custom coder proto %v
for type %v: %v", c, c.Type, err)
Review comment:
Missed removing the "proto " bits throughout this file. I think it's because
it's in the second file, understandable oversight. That's why we review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 216457)
> Improve error messages for unregistered protos
> ----------------------------------------------
>
> Key: BEAM-6838
> URL: https://issues.apache.org/jira/browse/BEAM-6838
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> When users have a type that can't be serialized (it has a function Field or
> similar) or more complex protocol buffers, the error should be improved to
> display the type being registered, and better yet, the beam.RegisterType(...)
> code they can use to enable use of their type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
