[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=683448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683448
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 16:41
Start Date: 18/Nov/21 16:41
Worklog Time Spent: 10m
Work Description: benWize commented on pull request #15742:
URL: https://github.com/apache/beam/pull/15742#issuecomment-973042442
> I looked this over, but I still haven't gotten through everything. I would
like to actually review all the changes closely since these have the potential
to break users. But that's going to make it really hard to get this in... by
the time I'm done looking it all over there will surely be merge conflicts. I
think we should try to break this up a little bit to avoid merge conflicts, and
make it easier for multiple people to review.
>
> I just proposed #16010 which adds a configuration variable
`suppressUnusedVariable: true` to every build.gradle. If you're ok with it, we
could merge that change, and then you'd be able to send a few PRs that enable
the unused variable warning for a few related packages at once (e.g. one for
all SQL extensions, one for all IOs, one for all runners). We should be able to
distribute the reviews for those PRs, and get them merged quick enough to avoid
conflicts. What do you think?
I am ok with breaking up this PR into smaller ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683448)
Time Spent: 33h 50m (was: 33h 40m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 33h 50m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
