[
https://issues.apache.org/jira/browse/BEAM-12999?focusedWorklogId=683465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683465
]
ASF GitHub Bot logged work on BEAM-12999:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 17:07
Start Date: 18/Nov/21 17:07
Worklog Time Spent: 10m
Work Description: kw2542 commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r752450960
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java
##########
@@ -422,6 +423,38 @@ public void translateNode(
}
}
+ private static class ReshuffleKeysTranslatorBatch<K, InputT>
+ implements
FlinkBatchPipelineTranslator.BatchTransformTranslator<Reshuffle.Keys<K,
InputT>> {
+
+ @Override
+ public void translateNode(
Review comment:
Updated and moved duplicate code in shared method/util.
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/streaming/StreamingTransformTranslator.java
##########
@@ -530,6 +530,38 @@ public String toNativeString() {
};
}
+ private static <K, V, W extends BoundedWindow>
TransformEvaluator<Reshuffle.Keys<K, V>> reshuffleKeys() {
Review comment:
Updated and moved duplicate code in shared method/util.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683465)
Time Spent: 18h 20m (was: 18h 10m)
> Improve Reshuffle Transform
> ---------------------------
>
> Key: BEAM-12999
> URL: https://issues.apache.org/jira/browse/BEAM-12999
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, sdk-java-core, sdk-py-core
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 18h 20m
> Remaining Estimate: 0h
>
> See discussion
> [https://lists.apache.org/thread.html/r83adaad3a512ad186f2f9dc9dc4bec2a789070677c07cdcaad6fcfa5%40%3Cdev.beam.apache.org%3E]
>
>
> “beam:transform:reshuffle:v1" Transform represents different semantic
> transforms in different SDKs. The proposal is to replace
> "beam:transform:reshuffle:v1" with two new urns, one to represent reshuffle
> KV PCollection using the K, and the other to reshuffle based on random key.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
