[
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=683584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683584
]
ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 19:02
Start Date: 18/Nov/21 19:02
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #16011:
URL: https://github.com/apache/beam/pull/16011#discussion_r752438052
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/model/ChangeStreamRecordMetadata.java
##########
@@ -0,0 +1,409 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.spanner.changestreams.model;
+
+import com.google.cloud.Timestamp;
+import java.io.Serializable;
+import java.util.Objects;
+import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.annotations.VisibleForTesting;
+
+/** Holds internal execution metrics / metadata for the processed {@link
ChangeStreamRecord}. */
+public class ChangeStreamRecordMetadata implements Serializable {
Review comment:
by implementing `Serializable` I suppose you're wanting to enable Beam
to serialize your records using Java serialization. This makes sense, but you
may want to consider removing the serializable, and instead annotating them
with `@DefaultSchema(JavaBeanSchema.class)`.
Reasons why you may want to do that:
- Beam serialization is faster and more compact than Java serialization
- By adding a schema to it, you can apply 'smart' transformations to your
data (e.g. `.apply(Select.columns("recordTimestamp", "partitionToken"));`
See
https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/schemas/annotations/DefaultSchema.html
and
see
https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/schemas/JavaBeanSchema.html
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/model/ChangeStreamRecordMetadata.java
##########
@@ -0,0 +1,409 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.spanner.changestreams.model;
+
+import com.google.cloud.Timestamp;
+import java.io.Serializable;
+import java.util.Objects;
+import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.annotations.VisibleForTesting;
+
+/** Holds internal execution metrics / metadata for the processed {@link
ChangeStreamRecord}. */
+public class ChangeStreamRecordMetadata implements Serializable {
Review comment:
The only thing to keep in mind (and maybe the reason why you're using
Java serialization) is that you can only have one schema per PCollection - so
if you have records of multiple kinds in the same PCollection, this approach
may not be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683584)
Time Spent: 50m (was: 40m)
> SpannerIO Change Stream Connector
> ---------------------------------
>
> Key: BEAM-12164
> URL: https://issues.apache.org/jira/browse/BEAM-12164
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Thiago Nunes
> Priority: P3
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
> with the support for Spanner Change Streams (CDC). CDC support is just being
> implemented in Spanner and it will be exposed through a gRPC API. We will use
> such API to create a new SpannerIO.readChangeStream(...) implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
