[
https://issues.apache.org/jira/browse/BEAM-6875?focusedWorklogId=216740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216740
]
ASF GitHub Bot logged work on BEAM-6875:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/19 13:31
Start Date: 21/Mar/19 13:31
Worklog Time Spent: 10m
Work Description: je-ik commented on pull request #8106: [BEAM-6875]
expose timestampSkew to user in FlatMap#eventTimeBy
URL: https://github.com/apache/beam/pull/8106#discussion_r267756443
##########
File path:
sdks/java/extensions/euphoria/src/main/java/org/apache/beam/sdk/extensions/euphoria/core/client/operator/FlatMap.java
##########
@@ -153,7 +154,21 @@ public static OfBuilder named(@Nullable String name) {
* @param eventTimeFn the event time extraction function
* @return the next builder to complete the setup of the {@link FlatMap}
operator
*/
- Builders.Output<OutputT> eventTimeBy(ExtractEventTime<InputT> eventTimeFn);
+ default Builders.Output<OutputT> eventTimeBy(ExtractEventTime<InputT>
eventTimeFn) {
+ // allowed timestamp shifts to infitive past
+ return eventTimeBy(eventTimeFn, Long.MAX_VALUE);
Review comment:
The default favors functionality. We cannot know if the assignment function
moves timestamps forward or backward, so this default ensures that any
assignment will work. Moreover (if I understand it correctly) it has no
performance or any other penalty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 216740)
Time Spent: 50m (was: 40m)
> Euphoria: Timestamp manipulation functions have to expose timestampSkew to
> user
> -------------------------------------------------------------------------------
>
> Key: BEAM-6875
> URL: https://issues.apache.org/jira/browse/BEAM-6875
> Project: Beam
> Issue Type: Bug
> Components: dsl-euphoria
> Affects Versions: 2.11.0
> Reporter: Jan Lukavský
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When we reassign timestamps we need to set \{{DoFn#getAllowedTimestampSkew}}
> or exception might be raised when assigning timestamps behind watermark.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
