[ 
https://issues.apache.org/jira/browse/BEAM-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447409#comment-17447409
 ] 

Ananda Prasad Inguva edited comment on BEAM-3046 at 11/22/21, 1:42 PM:
-----------------------------------------------------------------------

Ben chamber's doc: 
[https://docs.google.com/document/d/1voyUIQ2DrWkoY-BsJwM8YvF4gGKB76CDG8BYL8XBc7A/edit#heading=h.m3vu8fd66s5y]

 

Pablos' doc: 
https://docs.google.com/document/d/1TsZMcfdwqbVDCqAX8-BjcBssyKQza8XHQ_FDLXsDe_0/edit#


was (Author: anand inguva):
Ben chamber's doc: 
[https://docs.google.com/document/d/1voyUIQ2DrWkoY-BsJwM8YvF4gGKB76CDG8BYL8XBc7A/edit#heading=h.m3vu8fd66s5y]

 

> De-javafy the Python Metrics API
> --------------------------------
>
>                 Key: BEAM-3046
>                 URL: https://issues.apache.org/jira/browse/BEAM-3046
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Ananda Prasad Inguva
>            Priority: P3
>              Labels: community-onboarding, starter, triaged
>             Fix For: 3.0.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> For example, though Java forces one to put all stand-alone functions as 
> static methods on a class (like Metrics) in Python one would just have 
> standard module-level functions. 
> Also, the MetricsFilter builder pattern is very Java-esque (and verbose). In 
> Python, one would simply let result.metrics() take keyword arguments. 
> We should seriously consider aggregating rather than returning lists of 
> results, at least by default. E.g. in 
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/wordcount.py
>  it assumes that there's no other metric with the given name in any 
> subtransform (otherwise it may deterministically grab the "wrong" one.)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to