[
https://issues.apache.org/jira/browse/BEAM-13091?focusedWorklogId=685027&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685027
]
ASF GitHub Bot logged work on BEAM-13091:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 01:23
Start Date: 23/Nov/21 01:23
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#15765:
URL: https://github.com/apache/beam/pull/15765#discussion_r754747414
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -870,16 +873,26 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
} catch (InvalidProtocolBufferException e) {
throw new RuntimeException("Error parsing artifact file payload.",
e);
}
- if (!BeamUrns.getUrn(RunnerApi.StandardArtifacts.Roles.STAGING_TO)
+ String stagedName;
+ if (BeamUrns.getUrn(RunnerApi.StandardArtifacts.Roles.STAGING_TO)
.equals(info.getRoleUrn())) {
- throw new RuntimeException(
- String.format("unsupported artifact role %s",
info.getRoleUrn()));
- }
- RunnerApi.ArtifactStagingToRolePayload stagingPayload;
- try {
- stagingPayload =
RunnerApi.ArtifactStagingToRolePayload.parseFrom(info.getRolePayload());
- } catch (InvalidProtocolBufferException e) {
- throw new RuntimeException("Error parsing artifact staging_to role
payload.", e);
+ try {
+ RunnerApi.ArtifactStagingToRolePayload stagingPayload =
+
RunnerApi.ArtifactStagingToRolePayload.parseFrom(info.getRolePayload());
+ stagedName = stagingPayload.getStagedName();
+ } catch (InvalidProtocolBufferException e) {
+ throw new RuntimeException("Error parsing artifact staging_to role
payload.", e);
+ }
+ } else {
+ try {
+ File source = new File(filePayload.getPath());
+ HashCode hashCode =
Files.asByteSource(source).hash(Hashing.sha256());
Review comment:
Do you know how expensive this is ? Could this add a significant
overhead to the Job submission time ?
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -870,16 +873,26 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
} catch (InvalidProtocolBufferException e) {
throw new RuntimeException("Error parsing artifact file payload.",
e);
}
- if (!BeamUrns.getUrn(RunnerApi.StandardArtifacts.Roles.STAGING_TO)
+ String stagedName;
+ if (BeamUrns.getUrn(RunnerApi.StandardArtifacts.Roles.STAGING_TO)
.equals(info.getRoleUrn())) {
- throw new RuntimeException(
- String.format("unsupported artifact role %s",
info.getRoleUrn()));
- }
- RunnerApi.ArtifactStagingToRolePayload stagingPayload;
- try {
- stagingPayload =
RunnerApi.ArtifactStagingToRolePayload.parseFrom(info.getRolePayload());
- } catch (InvalidProtocolBufferException e) {
- throw new RuntimeException("Error parsing artifact staging_to role
payload.", e);
+ try {
+ RunnerApi.ArtifactStagingToRolePayload stagingPayload =
+
RunnerApi.ArtifactStagingToRolePayload.parseFrom(info.getRolePayload());
+ stagedName = stagingPayload.getStagedName();
+ } catch (InvalidProtocolBufferException e) {
+ throw new RuntimeException("Error parsing artifact staging_to role
payload.", e);
+ }
+ } else {
+ try {
+ File source = new File(filePayload.getPath());
+ HashCode hashCode =
Files.asByteSource(source).hash(Hashing.sha256());
Review comment:
Is it possible to use a hash of the File path instead of file data ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 685027)
Time Spent: 50m (was: 40m)
> Generate missing staged names from hash for Dataflow runner
> -----------------------------------------------------------
>
> Key: BEAM-13091
> URL: https://issues.apache.org/jira/browse/BEAM-13091
> Project: Beam
> Issue Type: Sub-task
> Components: cross-language, runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Generate missing staged names from hash for Dataflow runner
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
