[
https://issues.apache.org/jira/browse/BEAM-13193?focusedWorklogId=685450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685450
]
ASF GitHub Bot logged work on BEAM-13193:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 18:28
Start Date: 23/Nov/21 18:28
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #16051:
URL: https://github.com/apache/beam/pull/16051#discussion_r755402988
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -464,6 +465,9 @@ public BundleFinalizer getBundleFinalizer() {
request.getInstructionId(),
bundleProcessor.getInboundEndpointApiServiceDescriptors(),
observer);
+ if (request.getProcessBundle().hasElements()) {
+ observer.accept(request.getProcessBundle().getElements());
Review comment:
Wasn't the contract that all the data had to come from the
ProcessBundleRequest and if not that would be an error or did we swap back to
treating it like a prefix (you have implemented the latter)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 685450)
Time Spent: 7h 20m (was: 7h 10m)
> Optional data embedding in Fn API control request and response
> --------------------------------------------------------------
>
> Key: BEAM-13193
> URL: https://issues.apache.org/jira/browse/BEAM-13193
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Yichi Zhang
> Priority: P2
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> https://docs.google.com/document/d/14p8Y_n4IY5n9L_I9l5x9lVGgml4ZzdCw645HldndCrw/edit
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
