[
https://issues.apache.org/jira/browse/BEAM-11997?focusedWorklogId=686128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-686128
]
ASF GitHub Bot logged work on BEAM-11997:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/21 23:22
Start Date: 24/Nov/21 23:22
Worklog Time Spent: 10m
Work Description: lukecwik edited a comment on pull request #15549:
URL: https://github.com/apache/beam/pull/15549#issuecomment-978442241
> Updated RedisCursor compareTo to differentiate start and end, moved util
functions to RedisCursorRangeTrakcer. About the internal ByteKeyRangeTracker, I
removed it and moved its logic to the RedisCursorRangeTracker as having the
internal ByteKeyRangeTracker presented some problems, mainly that the trySplit
method would produce ranges with a starting key that was not a valid cursor
returned by redis (because of its next function adding 1 to the current
ByteKey) this caused problems on the test case with a large number of keys.
RedisCursorRangeTracker maintains the same logic used on ByteKeyRangeTracker
with the exception of a modified trySplit method.
You can convert the next() ByteKey cursor by rounding up to next closet
valid redis cursor. If the bytekey is 8 bytes (length of long) then you can
decode it using the BigEndianLongCoder and if its longer then 8 bytes then you
can truncate it down to 8 bytes decode it and add 1. This will allow you to
reuse the ByteKeyRangeTracker.
Note that the ByteKeyRangeTracker has a lot of logic which has been well
tested so duplicating it is very likely to create subtle errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 686128)
Time Spent: 7.5h (was: 7h 20m)
> Implement RedisIO on top of Splittable DoFn
> -------------------------------------------
>
> Key: BEAM-11997
> URL: https://issues.apache.org/jira/browse/BEAM-11997
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Reporter: Boyuan Zhang
> Assignee: Miguel Anzo
> Priority: P2
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
