[
https://issues.apache.org/jira/browse/BEAM-12565?focusedWorklogId=686602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-686602
]
ASF GitHub Bot logged work on BEAM-12565:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/21 17:26
Start Date: 25/Nov/21 17:26
Worklog Time Spent: 10m
Work Description: roger-mike commented on a change in pull request #16027:
URL: https://github.com/apache/beam/pull/16027#discussion_r757057234
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -3441,6 +3460,18 @@ def value_counts(self, subset=None, sort=False,
normalize=False,
else:
return result
+ @frame_base.with_docs_from(pd.DataFrame)
+ @frame_base.args_to_kwargs(pd.DataFrame)
+ @frame_base.populate_defaults(pd.DataFrame)
+ def compare(self, other, **kwargs):
Review comment:
Hi @TheNeuralBit, I have a similar issue here as in `idxmin` and
`idxmax` proxy. I wasn't able to create a valid proxy since the expected proxy
is a DataFrame with a MultiIndex and its structure depends on the differences
between the inputs. So, I'm not sure how this proxy can be created beforehand.
Any suggestion on how this can be solved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 686602)
Time Spent: 20m (was: 10m)
> Implement compare for DataFrame and Series
> ------------------------------------------
>
> Key: BEAM-12565
> URL: https://issues.apache.org/jira/browse/BEAM-12565
> Project: Beam
> Issue Type: Improvement
> Components: dsl-dataframe
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P3
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add an implementation of
> [compare|https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.compare.html]
> for DeferredDataFrame and DeferredSeries. It should be fully unit tested
> with some combination of pandas_doctests_test.py and frames_test.py.
> https://github.com/apache/beam/pull/14274 is an example of a typical PR that
> adds new operations. See
> https://lists.apache.org/thread.html/r8ffe96d756054610dfdb4e849ffc6a741e826d15ba7e5bdeee1b4266%40%3Cdev.beam.apache.org%3E
> for background on the DataFrame API.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
