[ 
https://issues.apache.org/jira/browse/BEAM-4152?focusedWorklogId=217080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217080
 ]

ASF GitHub Bot logged work on BEAM-4152:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Mar/19 01:07
            Start Date: 22/Mar/19 01:07
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on issue #8111: [BEAM-4152] Kinds & 
URNs for Session Windows
URL: https://github.com/apache/beam/pull/8111#issuecomment-475458435
 
 
   I've conferred with someone who knows the Java side better than me, and the 
exec stack side should be pretty straight forward, because sessions are known. 
You shouldn't need to implement any merge logic on the SDK side.
   
   
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/window.go#L57
 should be very similar to fixed window. 
   
   The other next spot would be to ensure that there's a coder for the windows 
from the exec side:
   You can see how the others are implemented here:
   
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/coder.go#L274
 
   
   The Runner in principle should handle the merging following a 
GroupByKey/Combine operation.
   
   Note: This wouldn't be handled properly in the Go SDK direct runner, that's 
where the sorting and merging would need to happen based on the configured gap 
size.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 217080)
    Time Spent: 1h 20m  (was: 1h 10m)

> Support Go session windowing
> ----------------------------
>
>                 Key: BEAM-4152
>                 URL: https://issues.apache.org/jira/browse/BEAM-4152
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Support session windowing and how to handle merging windows.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to