[
https://issues.apache.org/jira/browse/BEAM-12697?focusedWorklogId=687548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687548
]
ASF GitHub Bot logged work on BEAM-12697:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 19:15
Start Date: 29/Nov/21 19:15
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15733:
URL: https://github.com/apache/beam/pull/15733#discussion_r758661753
##########
File path:
sdks/java/extensions/sbe/src/main/java/org/apache/beam/sdk/extensions/sbe/SbeLogicalTypes.java
##########
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sbe;
+
+import java.time.Instant;
+import java.time.LocalDate;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.annotations.Experimental.Kind;
+import org.apache.beam.sdk.schemas.Schema.FieldType;
+import org.apache.beam.sdk.schemas.Schema.LogicalType;
+import org.apache.beam.sdk.schemas.logicaltypes.PassThroughLogicalType;
+import org.checkerframework.checker.initialization.qual.Initialized;
+import org.checkerframework.checker.nullness.qual.NonNull;
+import org.checkerframework.checker.nullness.qual.Nullable;
+import org.checkerframework.checker.nullness.qual.UnknownKeyFor;
+
+/**
+ * Classes that represent various SBE semantic types.
+ *
+ * <p>Not all of SBE's semantic types are represented here, as some can be
reasonably represented in
+ * Beam schemas with just a primitive.
+ */
+@Experimental(Kind.SCHEMAS)
+public final class SbeLogicalTypes {
Review comment:
nit: You might consider making all the LogicalType implementations
private, and just exposing concrete instances of them here. I'm also fine
merging as-is if you'd prefer
This is what we did in SqlTypes, so that we can easily migrate if/when it's
necessary:
https://github.com/apache/beam/blob/d50012996f39eff3aa881d6555c0a54eea9b60f7/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/SqlTypes.java#L32-L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687548)
Time Spent: 17.5h (was: 17h 20m)
> SBE Extension
> -------------
>
> Key: BEAM-12697
> URL: https://issues.apache.org/jira/browse/BEAM-12697
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Zachary Houfek
> Assignee: Zachary Houfek
> Priority: P2
> Time Spent: 17.5h
> Remaining Estimate: 0h
>
> This is a prerequisite to BEAM-12298.
> The intent is to add an extension for Simple Binary Encoding, similar to what
> exists for Protobuf.
> Design doc:
> [https://docs.google.com/document/d/1YiZR__1EsV9tDFsNUhvbpv2YjeP5cMl1c3Wj7Nb1fWs|https://docs.google.com/document/d/1q2KyBxPQ6V6Gfm50Z74YWofATgVauYu066F0t1JPxRU/edit?usp=sharing]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
