[
https://issues.apache.org/jira/browse/BEAM-12561?focusedWorklogId=687670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687670
]
ASF GitHub Bot logged work on BEAM-12561:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 23:08
Start Date: 29/Nov/21 23:08
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15833:
URL: https://github.com/apache/beam/pull/15833#discussion_r758805395
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -53,12 +53,7 @@ def test_ndframe_tests(self):
# frames_test.py
"s.tz_localize('CET', ambiguous=np.array([True, True,
False]))",
],
- 'pandas.core.generic.NDFrame.truncate': [
- # These inputs rely on tail (wont implement, order
- # sensitive) for verification
- "df.tail()",
- "df.loc['2016-01-05':'2016-01-10', :].tail()",
- ],
+ 'pandas.core.generic.NDFrame.truncate': ['*'],
Review comment:
Can we remove this, so that truncate is tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687670)
Time Spent: 3h (was: 2h 50m)
> Implement truncate for DataFrame and Series
> -------------------------------------------
>
> Key: BEAM-12561
> URL: https://issues.apache.org/jira/browse/BEAM-12561
> Project: Beam
> Issue Type: Improvement
> Components: dsl-dataframe
> Reporter: Brian Hulette
> Priority: P3
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add an implementation of
> [truncate|https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.truncate.html]
> for DeferredDataFrame, and DeferredSeries. It should be fully unit tested
> with some combination of pandas_doctests_test.py and frames_test.py.
> https://github.com/apache/beam/pull/14274 is an example of a typical PR that
> adds new operations. See
> https://lists.apache.org/thread.html/r8ffe96d756054610dfdb4e849ffc6a741e826d15ba7e5bdeee1b4266%40%3Cdev.beam.apache.org%3E
> for background on the DataFrame API.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
