[
https://issues.apache.org/jira/browse/BEAM-13135?focusedWorklogId=687962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687962
]
ASF GitHub Bot logged work on BEAM-13135:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/21 12:00
Start Date: 30/Nov/21 12:00
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on a change in pull request
#16072:
URL: https://github.com/apache/beam/pull/16072#discussion_r759209428
##########
File path: playground/infrastructure/helper.py
##########
@@ -44,29 +54,221 @@ def find_examples(work_dir: str) -> List[Example]:
categories:
- category-1
- category-2
+ If some example contain beam tag with incorrect format raise an error.
Args:
work_dir: directory where to search examples.
+ supported_categories: list of supported categories.
Returns:
List of Examples.
"""
- # TODO [BEAM-13135] Implement
- pass
+ has_error = False
+ examples = []
+ for root, _, files in os.walk(work_dir):
Review comment:
Yes. I have run a little test to check how long this method works. Now
it takes about 16 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687962)
Time Spent: 40m (was: 0.5h)
> [Playground] Validate step in Beam CI pipelines for Playground objects
> ----------------------------------------------------------------------
>
> Key: BEAM-13135
> URL: https://issues.apache.org/jira/browse/BEAM-13135
> Project: Beam
> Issue Type: New Feature
> Components: beam-playground
> Reporter: Ilya Kozyrev
> Priority: P3
> Labels: beam-playground-devops, beam-playground-sprint-3,
> beam-playground-sprint-4, beam-playground-sprint-5
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As an Apache Beam *maintainer* who develops examples, katas, or unit tests, I
> want to have a validation step in the CI pipeline for my Pull Request into
> the Apache Beam repository. This step should check tagged objects for
> Playground and give feedback in PR if something went wrong.
> *Acceptance criteria:*
> # Search Tags in the Apache Beam codebase
> # Tag format validations for objects
> # Compilation validation for tagged objects
> # Verification for running ability in the Playground environment
> # Feedback sends in Pull Request
> *Scenario:* CI script found object available for Playground usage
> *Given:* CI is triggered for new PR
> *When:* CI script scan file in apache beam repository
> *And:* File contained Playground tag
> *Then:* CI Validates this file for usage in Playground
>
> *Given:* CI found tagged object
> *When:* CI runs validation for tag format
> *And:* Validation is complete
> *Then:* CI starts the compilation for this object
>
> *Given:* CI found tagged object
> *When:* CI runs validation for tag format
> *And:* Validation is failed
> *Then:* CI task ends with an error and feedback received to PR
> –
> *Given:* Validation is complete
> *When:* CI runs compilation for object
> *And:* Compilation is complete
> *Then:* CI starts the run step for this object
> –
> *Given:* Validation is complete
> *When:* CI runs compilation for object
> *And:* Compilation is failed
> *Then:* CI task ends with an error and feedback received to PR
> –
> *Given:* Compilation is complete
> *When:* CI runs object's code in Playground
> *And:* Run step is complete
> *Then:* CI Ends successfully
>
> *Given:* Compilation is complete
> *When:* CI runs object's code in Playground
> *And:* Run step
> *Then:* CI task ends with an error and feedback received to PR
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
