[
https://issues.apache.org/jira/browse/BEAM-13360?focusedWorklogId=688619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-688619
]
ASF GitHub Bot logged work on BEAM-13360:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/21 12:32
Start Date: 01/Dec/21 12:32
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on pull request #16095:
URL: https://github.com/apache/beam/pull/16095#issuecomment-983596585
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 688619)
Time Spent: 20m (was: 10m)
> [Playground] Fix synchronous validators
> ---------------------------------------
>
> Key: BEAM-13360
> URL: https://issues.apache.org/jira/browse/BEAM-13360
> Project: Beam
> Issue Type: Bug
> Components: beam-playground
> Reporter: Ilya Kozyrev
> Assignee: Aydar Zaynutdinov
> Priority: P2
> Labels: beam-playground-backend, beam-playground-sprint-5
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For validators, we start a single goroutine for validateFunc in which we loop
> through all validators synchronously.
>
> {code:java}
> go validateFunc(successChannel, errorChannel, valResChannel)
> // Validate returns the function that applies all validators of executor
> func (ex *Executor) Validate() func(chan bool, chan error) {
> return func(doneCh chan bool, errCh chan error) {
> for _, validator := range ex.validators {
> err := validator.Validator(validator.Args...)
> if err != nil {
> errCh <- err
> doneCh <- false
> return
> }
> }
> doneCh <- true
> }
> }
> {code}
>
> Instead of that, we should start goroutines for each loop step. And control
> results for each validator with separate channels.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
