[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=688789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-688789
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/21 17:02
Start Date: 01/Dec/21 17:02
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #16035:
URL: https://github.com/apache/beam/pull/16035#discussion_r760384882
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/AssignWindowsParDoFnFactory.java
##########
@@ -68,14 +68,12 @@ public ParDoFn create(
}
private static class AssignWindowsParDoFn<T, W extends BoundedWindow>
implements ParDoFn {
- private final DataflowExecutionContext.DataflowStepContext stepContext;
private final WindowFn<T, W> windowFn;
private @Nullable Receiver receiver;
AssignWindowsParDoFn(
WindowFn<T, W> windowFn, DataflowExecutionContext.DataflowStepContext
stepContext) {
Review comment:
Yes, I removed it
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/QueryablePipelineTest.java
##########
@@ -428,18 +428,5 @@ public void retainOnlyPrimitivesIgnoresUnreachableNodes() {
.apply(MapElements.into(TypeDescriptors.longs()).via(l -> l +
1));
}
});
-
- Components augmentedComponents =
- PipelineTranslation.toProto(p)
- .getComponents()
- .toBuilder()
- .putCoders("extra-coder", RunnerApi.Coder.getDefaultInstance())
- .putWindowingStrategies(
- "extra-windowing-strategy",
RunnerApi.WindowingStrategy.getDefaultInstance())
- .putEnvironments("extra-env",
RunnerApi.Environment.getDefaultInstance())
- .putPcollections("extra-pc",
RunnerApi.PCollection.getDefaultInstance())
- .build();
- Collection<String> primitiveComponents =
- QueryablePipeline.getPrimitiveTransformIds(augmentedComponents);
Review comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 688789)
Time Spent: 44h 20m (was: 44h 10m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 44h 20m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
