[
https://issues.apache.org/jira/browse/BEAM-13369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Moritz Mack updated BEAM-13369:
-------------------------------
Description:
An implementation of "equals" of the source seems to be expected/required when
doing a bounded read from an unbounded source. If doing so, logs are full of
warnings and fairly disturbing, see below. Same also applies, for instance, to
the Kafka Source.
Should KinesisSource (and dependencies) implement equals both in SDK v1 and v2.
{code:java}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@4f478720,
maxNumRecords=1000, maxReadTime=PT600S}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
maxNumRecords=1000, maxReadTime=PT600S}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.KvCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element KV{689044774,
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
maxNumRecords=1000, maxReadTime=PT600S}}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
maxNumRecords=1000, maxReadTime=PT600S}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.KvCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element KV{689044774,
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@47b75d1c,
maxNumRecords=1000, maxReadTime=PT600S}} {code}
was:
An implementation of "equals" of the source seems to be expected/required when
doing a bounded read from an unbounded source.
Same applies, for instance, to the Kafka Source.
KinesisSource and related should implement equals both in SDK v1 and v2.
{code:java}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@4f478720,
maxNumRecords=1000, maxReadTime=PT600S}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
maxNumRecords=1000, maxReadTime=PT600S}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.KvCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element KV{689044774,
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
maxNumRecords=1000, maxReadTime=PT600S}}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
maxNumRecords=1000, maxReadTime=PT600S}
Dec 02, 2021 10:28:53 AM
org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
verifyUnmodifiedThrowingCheckedExceptions
WARNING: Coder of type class org.apache.beam.sdk.coders.KvCoder has a
#structuralValue method which does not return true when the encoding of the
elements is equal. Element KV{689044774,
Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@47b75d1c,
maxNumRecords=1000, maxReadTime=PT600S}} {code}
> MutationDetector warns due to missing equals method in KinesisSource
> --------------------------------------------------------------------
>
> Key: BEAM-13369
> URL: https://issues.apache.org/jira/browse/BEAM-13369
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P3
> Labels: aws, kinesis
>
> An implementation of "equals" of the source seems to be expected/required
> when doing a bounded read from an unbounded source. If doing so, logs are
> full of warnings and fairly disturbing, see below. Same also applies, for
> instance, to the Kafka Source.
> Should KinesisSource (and dependencies) implement equals both in SDK v1 and
> v2.
> {code:java}
> Dec 02, 2021 10:28:53 AM
> org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
> verifyUnmodifiedThrowingCheckedExceptions
> WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has
> a #structuralValue method which does not return true when the encoding of the
> elements is equal. Element
> Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@4f478720,
> maxNumRecords=1000, maxReadTime=PT600S}
> Dec 02, 2021 10:28:53 AM
> org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
> verifyUnmodifiedThrowingCheckedExceptions
> WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has
> a #structuralValue method which does not return true when the encoding of the
> elements is equal. Element
> Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
> maxNumRecords=1000, maxReadTime=PT600S}
> Dec 02, 2021 10:28:53 AM
> org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
> verifyUnmodifiedThrowingCheckedExceptions
> WARNING: Coder of type class org.apache.beam.sdk.coders.KvCoder has a
> #structuralValue method which does not return true when the encoding of the
> elements is equal. Element KV{689044774,
> Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
> maxNumRecords=1000, maxReadTime=PT600S}}
> Dec 02, 2021 10:28:53 AM
> org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
> verifyUnmodifiedThrowingCheckedExceptions
> WARNING: Coder of type class org.apache.beam.sdk.coders.SerializableCoder has
> a #structuralValue method which does not return true when the encoding of the
> elements is equal. Element
> Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@1176f162,
> maxNumRecords=1000, maxReadTime=PT600S}
> Dec 02, 2021 10:28:53 AM
> org.apache.beam.sdk.util.MutationDetectors$CodedValueMutationDetector
> verifyUnmodifiedThrowingCheckedExceptions
> WARNING: Coder of type class org.apache.beam.sdk.coders.KvCoder has a
> #structuralValue method which does not return true when the encoding of the
> elements is equal. Element KV{689044774,
> Shard{source=org.apache.beam.sdk.io.kinesis.KinesisSource@47b75d1c,
> maxNumRecords=1000, maxReadTime=PT600S}} {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
