[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=690330&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690330
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/21 21:37
Start Date: 03/Dec/21 21:37
Worklog Time Spent: 10m
Work Description: y1chi commented on a change in pull request #16037:
URL: https://github.com/apache/beam/pull/16037#discussion_r762301375
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/FinalizeBundleHandler.java
##########
@@ -65,45 +59,13 @@ public static CallbackRegistration create(
public abstract BundleFinalizer.Callback getCallback();
}
- private static final Logger LOG =
LoggerFactory.getLogger(FinalizeBundleHandler.class);
private final ConcurrentMap<String, Collection<CallbackRegistration>>
bundleFinalizationCallbacks;
private final PriorityQueue<TimestampedValue<String>> cleanUpQueue;
- private final Future<Void> cleanUpResult;
- public FinalizeBundleHandler(ExecutorService executorService) {
+ public FinalizeBundleHandler() {
this.bundleFinalizationCallbacks = new ConcurrentHashMap<>();
this.cleanUpQueue =
new PriorityQueue<>(11,
Comparator.comparing(TimestampedValue::getTimestamp));
- this.cleanUpResult =
Review comment:
is this safe to remove, will the bundleFinalizationCallbacks leak
without this task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 690330)
Time Spent: 49.5h (was: 49h 20m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 49.5h
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
