[ 
https://issues.apache.org/jira/browse/BEAM-13363?focusedWorklogId=690856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690856
 ]

ASF GitHub Bot logged work on BEAM-13363:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Dec/21 09:31
            Start Date: 06/Dec/21 09:31
    Worklog Time Spent: 10m 
      Work Description: daria-malkova commented on a change in pull request 
#16119:
URL: https://github.com/apache/beam/pull/16119#discussion_r762833819



##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -44,11 +44,12 @@ const (
 )
 
 type ObjectInfo struct {
-       Name        string
-       CloudPath   string
-       Description string                   
`protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
-       Type        pb.PrecompiledObjectType 
`protobuf:"varint,4,opt,name=type,proto3,enum=api.v1.PrecompiledObjectType" 
json:"type,omitempty"`
-       Categories  []string                 `json:"categories,omitempty"`
+       Name            string
+       CloudPath       string
+       Description     string                   
`protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
+       Type            pb.PrecompiledObjectType 
`protobuf:"varint,4,opt,name=type,proto3,enum=api.v1.PrecompiledObjectType" 
json:"type,omitempty"`
+       Categories      []string                 `json:"categories,omitempty"`
+       PipelineOptions string                   
`protobuf:"bytes,3,opt,name=pipeline_options,proto3" 
json:"pipeline_options,omitempty"`

Review comment:
       Now if the pipeline_options field is empty, it will be omitted. Is it 
fine for PrecompiledObject message? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 690856)
    Time Spent: 40m  (was: 0.5h)

> [Playground] Add pipeline options support for Examples API
> ----------------------------------------------------------
>
>                 Key: BEAM-13363
>                 URL: https://issues.apache.org/jira/browse/BEAM-13363
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-playground
>            Reporter: Ilya Kozyrev
>            Assignee: Aydar Zaynutdinov
>            Priority: P2
>              Labels: beam-playground-backend, beam-playground-frontend, 
> beam-playground-sprint-5
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Many examples have pipeline options that are required to run a particular 
> beam pipeline, such as input/output paths and so on.
>  
> Need to add functionality for retrieving extracted pipeline options from 
> playground tag and pass them to the frontend client for each precompiled 
> example.
> h4.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to