[
https://issues.apache.org/jira/browse/BEAM-13366?focusedWorklogId=691816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-691816
]
ASF GitHub Bot logged work on BEAM-13366:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/21 15:15
Start Date: 07/Dec/21 15:15
Worklog Time Spent: 10m
Work Description: ilya-kozyrev commented on a change in pull request
#16127:
URL: https://github.com/apache/beam/pull/16127#discussion_r764093061
##########
File path: playground/backend/internal/executors/executor.go
##########
@@ -102,7 +104,9 @@ func (ex *Executor) Compile(ctx context.Context) *exec.Cmd {
// Returns Cmd instance
func (ex *Executor) Run(ctx context.Context) *exec.Cmd {
args := append(ex.runArgs.commandArgs, ex.runArgs.fileName)
- cmd := exec.CommandContext(ctx, ex.runArgs.commandName, args...)
+ argsWithOptions := append(args, ex.runArgs.pipelineOptions)
+ argsWithOptions = utils.RemoveEmptyValue(argsWithOptions)
Review comment:
it might come from the user side, i.e. --option1 \s\s option (2
whitespaces) and that valid command line way, however when we split to go cmd
we should remove extra spaces :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 691816)
Time Spent: 1.5h (was: 1h 20m)
> Add support Pipeline Options for Backend
> ----------------------------------------
>
> Key: BEAM-13366
> URL: https://issues.apache.org/jira/browse/BEAM-13366
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Ilya Kozyrev
> Assignee: Pavel Avilov
> Priority: P2
> Labels: beam-playground-backend, beam-playground-sprint-5
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> # Run code can take pipeline options in request
> # Executors can put options in Run command
> # Update gRPC client in ci/cd
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
