[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=692671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-692671
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Dec/21 15:23
Start Date: 08/Dec/21 15:23
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16037:
URL: https://github.com/apache/beam/pull/16037#discussion_r760535645
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/snippets/Snippets.java
##########
@@ -118,7 +118,8 @@
/** Code snippets used in webdocs. */
@SuppressWarnings({
"rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
- "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
+ "nullness", // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
+ "unused"
Review comment:
```suggestion
"unused" // TODO(BEAM-13271): Remove when new version of errorprone is
released (2.11.0)
```
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/FinalizeBundleHandler.java
##########
@@ -65,45 +59,13 @@ public static CallbackRegistration create(
public abstract BundleFinalizer.Callback getCallback();
}
- private static final Logger LOG =
LoggerFactory.getLogger(FinalizeBundleHandler.class);
private final ConcurrentMap<String, Collection<CallbackRegistration>>
bundleFinalizationCallbacks;
private final PriorityQueue<TimestampedValue<String>> cleanUpQueue;
- private final Future<Void> cleanUpResult;
- public FinalizeBundleHandler(ExecutorService executorService) {
+ public FinalizeBundleHandler() {
this.bundleFinalizationCallbacks = new ConcurrentHashMap<>();
this.cleanUpQueue =
new PriorityQueue<>(11,
Comparator.comparing(TimestampedValue::getTimestamp));
- this.cleanUpResult =
Review comment:
Should we be inspecting `cleanUpResult` at some point to make sure it
worked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 692671)
Time Spent: 57h 20m (was: 57h 10m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 57h 20m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
