[
https://issues.apache.org/jira/browse/BEAM-13341?focusedWorklogId=692732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-692732
]
ASF GitHub Bot logged work on BEAM-13341:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Dec/21 16:54
Start Date: 08/Dec/21 16:54
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#16080:
URL: https://github.com/apache/beam/pull/16080#discussion_r765048292
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java
##########
@@ -356,6 +358,10 @@ protected AvroCoder(Class<T> type, Schema schema, boolean
useReflectApi) {
return type;
}
+ public boolean usesReflection() {
Review comment:
I think we should use only one verb - either `is` or `use`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 692732)
Time Spent: 2h 10m (was: 2h)
> Serialization of AvroCoder for dataflow workers discard reflect option
> ----------------------------------------------------------------------
>
> Key: BEAM-13341
> URL: https://issues.apache.org/jira/browse/BEAM-13341
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.34.0
> Reporter: Michel Davit
> Assignee: Michel Davit
> Priority: P3
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> [AvroCoderCloudObjectTranslator|https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/AvroCoderCloudObjectTranslator.java]
> used to serialize AvroCoder to the dataflow worker does not take in account
> the 'useRelectApi'
> [AvroCoder|https://github.com/apache/beam/blob/f6e4aef7cc22ea934bde471fd2e2ea2c110721d4/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java#L131]
> parameter, and will deserialize coders with default value (true).
> The CloudObjectTranslator should propagate this setting so that the
> deserialized coder behaves the same way as the serialized one.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
