[
https://issues.apache.org/jira/browse/BEAM-13417?focusedWorklogId=694975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694975
]
ASF GitHub Bot logged work on BEAM-13417:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/21 11:10
Start Date: 13/Dec/21 11:10
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#16172:
URL: https://github.com/apache/beam/pull/16172#discussion_r767629071
##########
File path: playground/backend/internal/validators/java_validators_test.go
##########
@@ -63,14 +62,67 @@ func TestCheckIsUnitTests(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- got, err := CheckIsUnitTestJava(tt.args.args...)
+ got, err := checkIsUnitTestJava(tt.args.args...)
+ if (err != nil) != tt.wantErr {
+ t.Errorf("checkIsUnitTestJava error = %v,
wantErr %v", err, tt.wantErr)
+ return
+ }
+ if got != tt.want {
+ t.Errorf("checkIsUnitTestJava got = %v, want
%v", got, tt.want)
+ }
+ })
+ }
+}
+
+func TestCheckIsKataJava(t *testing.T) {
+ testValidatorArgs := getValidatorsArgs(javaUnitTestFilePath,
javaUnitTestPattern)
+ validatorArgs := getValidatorsArgs(javaCodePath, javaUnitTestPattern)
Review comment:
Shouldn't there be `javaKataFilePath` instead of `javaUnitTestFilePath `
and `javaKatasPattern` instead of `javaUnitTestPattern`?
##########
File path: playground/backend/internal/validators/validator.go
##########
@@ -15,7 +15,10 @@
package validators
-const UnitTestValidatorName = "UnitTest"
+const (
+ UnitTestValidatorName = "UnitTest"
+ KatasValidatorName = "Check if the pipeline is katas"
Review comment:
Shouldn't `KatasValidatorName` equal just `"Katas"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 694975)
Time Spent: 2h 50m (was: 2h 40m)
> [Playground] Add java preparator for run katas
> ----------------------------------------------
>
> Key: BEAM-13417
> URL: https://issues.apache.org/jira/browse/BEAM-13417
> Project: Beam
> Issue Type: Task
> Components: beam-playground
> Reporter: Pavel Avilov
> Assignee: Pavel Avilov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-5
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Add java preparator to run katas: preparator should remove the package line
> in the received katas.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
