[ 
https://issues.apache.org/jira/browse/BEAM-13209?focusedWorklogId=696729&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696729
 ]

ASF GitHub Bot logged work on BEAM-13209:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Dec/21 16:33
            Start Date: 15/Dec/21 16:33
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on a change in pull request 
#16239:
URL: https://github.com/apache/beam/pull/16239#discussion_r769794009



##########
File path: 
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/dynamodb/DynamoDBIOTest.java
##########
@@ -51,6 +55,8 @@
 import org.junit.rules.ExpectedException;
 import org.mockito.ArgumentCaptor;
 import org.mockito.Mockito;
+import org.slf4j.helpers.MessageFormatter;
+import org.testcontainers.shaded.com.google.common.collect.ImmutableMap;

Review comment:
       Was it intentional to use the testcontainers shaded guava here? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 696729)
    Time Spent: 1h 40m  (was: 1.5h)

> DynamoDBIO silently drops unprocessed items
> -------------------------------------------
>
>                 Key: BEAM-13209
>                 URL: https://issues.apache.org/jira/browse/BEAM-13209
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-aws
>            Reporter: Moritz Mack
>            Assignee: Moritz Mack
>            Priority: P1
>              Labels: aws, aws-sdk-v1, aws-sdk-v2, data-loss, dynamodb
>             Fix For: 2.36.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> `[batchWriteItem|https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_BatchWriteItem.html]`
>  might fail partially and return unprocessed items. Such partial failures are 
> not handled and result in a data loss.
> If hitting DynamoDB at scale it's rather likely to run into this.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to