[
https://issues.apache.org/jira/browse/BEAM-13271?focusedWorklogId=696731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696731
]
ASF GitHub Bot logged work on BEAM-13271:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/21 16:40
Start Date: 15/Dec/21 16:40
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16231:
URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16231](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(72eb349) into
[master](https://codecov.io/gh/apache/beam/commit/665a542e277e27df11830bb0785fc51293139e77?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(665a542) will **increase** coverage by `9.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 72eb349 differs from pull request most recent
head b92c299. Consider uploading reports for the commit b92c299 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16231 +/- ##
==========================================
+ Coverage 74.63% 83.66% +9.02%
==========================================
Files 643 447 -196
Lines 81190 61692 -19498
==========================================
- Hits 60594 51612 -8982
+ Misses 19626 10080 -9546
+ Partials 970 0 -970
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `87.80% <0.00%> (-2.44%)` | :arrow_down: |
|
[...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==)
| `78.26% <0.00%> (-1.45%)` | :arrow_down: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `90.00% <0.00%> (-1.00%)` | :arrow_down: |
|
[sdks/go/pkg/beam/beam.shims.go](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9iZWFtLnNoaW1zLmdv)
| | |
|
[.../pkg/beam/runners/universal/extworker/extworker.go](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3VuaXZlcnNhbC9leHR3b3JrZXIvZXh0d29ya2VyLmdv)
| | |
|
[sdks/go/pkg/beam/encoding.go](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9lbmNvZGluZy5nbw==)
| | |
|
[sdks/go/pkg/beam/internal/errors/errors.go](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pbnRlcm5hbC9lcnJvcnMvZXJyb3JzLmdv)
| | |
|
[...beam/core/runtime/harness/statecache/statecache.go](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9zdGF0ZWNhY2hlL3N0YXRlY2FjaGUuZ28=)
| | |
|
[sdks/go/pkg/beam/core/runtime/xlangx/registry.go](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUveGxhbmd4L3JlZ2lzdHJ5Lmdv)
| | |
|
[sdks/go/pkg/beam/runners/dataflow/dataflow.go](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93Lmdv)
| | |
| ... and [193
more](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[665a542...b92c299](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 696731)
Time Spent: 6h 10m (was: 6h)
> error-prone UnusedVariable check raises false positives for StateId and
> TimerId usages
> --------------------------------------------------------------------------------------
>
> Key: BEAM-13271
> URL: https://issues.apache.org/jira/browse/BEAM-13271
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> See https://github.com/google/error-prone/issues/2668. The next release of
> error-prone will contain https://github.com/google/error-prone/pull/2669 and
> https://github.com/google/error-prone/pull/2676, which will help us.
> Until then we've had to suppress the check in several places. This jira
> tracks upgrading to a new error-prone once released and removing the
> suppressions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
