[
https://issues.apache.org/jira/browse/BEAM-12931?focusedWorklogId=696864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696864
]
ASF GitHub Bot logged work on BEAM-12931:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/21 20:24
Start Date: 15/Dec/21 20:24
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #15540:
URL: https://github.com/apache/beam/pull/15540#issuecomment-953406612
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15540](https://codecov.io/gh/apache/beam/pull/15540?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7b0de72) into
[master](https://codecov.io/gh/apache/beam/commit/bc82f6f84e72c520be397977edf4bf645782ac8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(bc82f6f) will **increase** coverage by `37.42%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7b0de72 differs from pull request most recent
head b3192dc. Consider uploading reports for the commit b3192dc to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/15540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15540 +/- ##
===========================================
+ Coverage 46.10% 83.53% +37.42%
===========================================
Files 196 445 +249
Lines 19498 61210 +41712
===========================================
+ Hits 8990 51131 +42141
- Misses 9538 10079 +541
+ Partials 970 0 -970
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/option.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb24uZ28=)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/encode.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9lbmNvZGUuZ28=)
| | |
|
[sdks/go/pkg/beam/impulse.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pbXB1bHNlLmdv)
| | |
|
[sdks/go/pkg/beam/create.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jcmVhdGUuZ28=)
| | |
|
[sdks/go/pkg/beam/metrics.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9tZXRyaWNzLmdv)
| | |
|
[sdks/go/pkg/beam/core/metrics/metrics.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL21ldHJpY3MvbWV0cmljcy5nbw==)
| | |
|
[sdks/go/pkg/beam/io/filesystem/memfs/memory.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL21lbWZzL21lbW9yeS5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/multiplex.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9tdWx0aXBsZXguZ28=)
| | |
|
[sdks/go/pkg/beam/core/runtime/harness/statemgr.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9zdGF0ZW1nci5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/graphx/coder.go](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ3JhcGh4L2NvZGVyLmdv)
| | |
| ... and [631
more](https://codecov.io/gh/apache/beam/pull/15540/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15540?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15540?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[bc82f6f...b3192dc](https://codecov.io/gh/apache/beam/pull/15540?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 696864)
Time Spent: 8.5h (was: 8h 20m)
> Timer.setOutputTimestamp doesn't take into account for
> DoFn#getAllowedTimestampSkew()
> -------------------------------------------------------------------------------------
>
> Key: BEAM-12931
> URL: https://issues.apache.org/jira/browse/BEAM-12931
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Lara Schmidt
> Assignee: Lara Schmidt
> Priority: P2
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> A DoFn may emit elements with a timestamp up to
> DoFn#getAllowedTimestampSkew() before the current element's timestamp.
> However getAllowedTimestampSkew is not properly accounted for in looking at
> the output timestamp of a timer.
> Context:
> [https://lists.apache.org/thread.html/r7554658114ddde86c5d82e1c39fe7e1ef587fe926b8e406d1130d501%40%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
