[
https://issues.apache.org/jira/browse/BEAM-13479?focusedWorklogId=698560&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-698560
]
ASF GitHub Bot logged work on BEAM-13479:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/21 10:39
Start Date: 20/Dec/21 10:39
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on a change in pull request
#16278:
URL: https://github.com/apache/beam/pull/16278#discussion_r772254817
##########
File path: playground/backend/cmd/server/controller.go
##########
@@ -74,6 +74,9 @@ func (controller *playgroundController) RunCode(ctx
context.Context, info *pb.Ru
if err = utils.SetToCache(ctx, controller.cacheService, pipelineId,
cache.LogsIndex, 0); err != nil {
return nil, errors.InternalError("Run code()", "Error during
set value to cache: %s", err.Error())
}
+ if err = utils.SetToCache(ctx, controller.cacheService, pipelineId,
cache.Canceled, false); err != nil {
+ return nil, errors.InternalError("Run code()", "Error during
set cancel flag to cache as a false")
Review comment:
add `code_processing.DeleteFolders(pipelineId, lc)`
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -336,12 +336,13 @@ func cancelCheck(ctx context.Context, pipelineId
uuid.UUID, cancelChannel chan b
case <-ticker.C:
cancel, err := cacheService.GetValue(ctx, pipelineId,
cache.Canceled)
if err != nil {
- continue
+ logger.Errorf("%s: Process: cache.GetValue:
error: %s", cancel, err.Error())
}
if cancel.(bool) {
cancelChannel <- true
+ return
}
- return
+ continue
Review comment:
it seems that there is no need to use `continue` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 698560)
Time Spent: 0.5h (was: 20m)
> [Playground] Change logic with Cancel method.
> ---------------------------------------------
>
> Key: BEAM-13479
> URL: https://issues.apache.org/jira/browse/BEAM-13479
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Pavel Avilov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-beta-launch
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Now server call method as a goroutine to check cancel flag.
> When the Cancel() method is called the cancel flag is set to the cache as a
> true.
> Need:
> * Set false flag as a default value before calling the Process method.
> * Change the logic of the cancelCheck() method. Now it checks that the flag
> cancel exists and after that returns from the method and stops goroutine.
> Need to change this logic and return from the method in case the cancel flag
> is true.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
