[
https://issues.apache.org/jira/browse/BEAM-13399?focusedWorklogId=698806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-698806
]
ASF GitHub Bot logged work on BEAM-13399:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/21 16:23
Start Date: 20/Dec/21 16:23
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16228:
URL: https://github.com/apache/beam/pull/16228#discussion_r772500933
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/download.go
##########
@@ -58,6 +58,10 @@ func GetBeamJar(gradleTarget, version string) (string,
error) {
}
func (j *jarGetter) getJar(gradleTarget, version string) (string, error) {
+ if strings.Contains(version, ".dev") {
Review comment:
It's worth noting that the Python SDK also routes .dev versioning
through gradle ([code reference
here](https://github.com/apache/beam/blob/8e217ea0d1f383ef5033ef507b14d01edf9c67e6/sdks/python/apache_beam/utils/subprocess_server.py#L233))
I could move the check to after the local cache check to fully emulate the
Python if we wanted to though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 698806)
Time Spent: 9h 20m (was: 9h 10m)
> [Go SDK] Add automated expansion service start up feature
> ---------------------------------------------------------
>
> Key: BEAM-13399
> URL: https://issues.apache.org/jira/browse/BEAM-13399
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> Add Go SDK support for automated expansion service start-up if one is not
> provided, following the example of the Python implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
