[
https://issues.apache.org/jira/browse/BEAM-12830?focusedWorklogId=699213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-699213
]
ASF GitHub Bot logged work on BEAM-12830:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/21 05:47
Start Date: 21/Dec/21 05:47
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16291:
URL: https://github.com/apache/beam/pull/16291#issuecomment-998433098
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16291](https://codecov.io/gh/apache/beam/pull/16291?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7974e0e) into
[master](https://codecov.io/gh/apache/beam/commit/3b492ad3fc4bac9b1fb9ce8b00981970885383e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(3b492ad) will **increase** coverage by `37.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/16291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16291 +/- ##
===========================================
+ Coverage 46.15% 83.67% +37.52%
===========================================
Files 197 447 +250
Lines 19522 61715 +42193
===========================================
+ Hits 9011 51642 +42631
- Misses 9540 10073 +533
+ Partials 971 0 -971
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/runners/direct/buffer.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RpcmVjdC9idWZmZXIuZ28=)
| | |
|
[sdks/go/pkg/beam/pipeline.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9waXBlbGluZS5nbw==)
| | |
|
[sdks/go/pkg/beam/util/harnessopts/sampler.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS91dGlsL2hhcm5lc3NvcHRzL3NhbXBsZXIuZ28=)
| | |
|
[sdks/go/pkg/beam/core/util/reflectx/util.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvdXRpbC5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/fn\_arity.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9mbl9hcml0eS5nbw==)
| | |
|
[sdks/go/pkg/beam/core/util/reflectx/structs.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvc3RydWN0cy5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/sdf\_invokers.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9zZGZfaW52b2tlcnMuZ28=)
| | |
|
[sdks/go/pkg/beam/xlang.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS94bGFuZy5nbw==)
| | |
|
[sdks/go/pkg/beam/coder.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb2Rlci5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/harness/session.go](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9zZXNzaW9uLmdv)
| | |
| ... and [634
more](https://codecov.io/gh/apache/beam/pull/16291/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16291?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16291?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[3b492ad...7974e0e](https://codecov.io/gh/apache/beam/pull/16291?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 699213)
Time Spent: 6h 10m (was: 6h)
> Remove GoGradle plugin
> ----------------------
>
> Key: BEAM-12830
> URL: https://issues.apache.org/jira/browse/BEAM-12830
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> GoGradle has never been updated to handle Go Modules, and it turns out it
> leaves .gogradle folders everywhere, which contain it's local gopath, and
> it's non-writable mod caches. This was the root cause of
> https://issues.apache.org/jira/browse/BEAM-12829.
> The solution is to stop using it, as it's never been ideal for our use, and
> replace it with direct shellouts to the go command.
> The main functionality that needs replacing is getting and using a set Go
> version so we can be sure what we're testing/validating against and building
> with, and using a common GoPath/ModuleCache throughout the repo. Otherwise,
> most instances can be replaced with simple tasks that call the Go function.
> A single module cache, if able to be reused across jenkins builds will also
> reduce build times. Note that these are for external versioned dependencies
> anyway, and not for Beam repo code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
