[
https://issues.apache.org/jira/browse/BEAM-11808?focusedWorklogId=699532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-699532
]
ASF GitHub Bot logged work on BEAM-11808:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/21 17:18
Start Date: 21/Dec/21 17:18
Worklog Time Spent: 10m
Work Description: benWize edited a comment on pull request #16200:
URL: https://github.com/apache/beam/pull/16200#issuecomment-991362866
Hi R: @ibzib could you help me to review the current progress of this?
I made this change
https://github.com/apache/beam/blob/d57f7c1ef3fff6b458cb8514460e157486d5648f/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperatorMappingTable.java#L116
to be able to get the delimiter from the argList here
https://github.com/apache/beam/blob/d57f7c1ef3fff6b458cb8514460e157486d5648f/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java#L183
because when this cast occurs, the argList is lost
https://github.com/apache/beam/blob/d57f7c1ef3fff6b458cb8514460e157486d5648f/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L235
Currently, the STRING_AGG's tests are passing
https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/3356/testReport/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/,
<del>but some checkstyle jobs are failing</del> (Fixed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 699532)
Time Spent: 1h (was: 50m)
> ZetaSQL layer doesn't support aggregate functions with two arguments
> ---------------------------------------------------------------------
>
> Key: BEAM-11808
> URL: https://issues.apache.org/jira/browse/BEAM-11808
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Sonam Ramchand
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Blocked by: parsed ZetaSQL to a Calcite logical expression doesn't currently
> support aggregate functions with multiple columns.
> [https://github.com/apache/beam/blob/3bb232fb098700de408f574585dfe74bbaff7230/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L147]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
