[ 
https://issues.apache.org/jira/browse/BEAM-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465980#comment-17465980
 ] 

Moritz Mack commented on BEAM-13509:
------------------------------------

[~aromanenko] I run into issues when testing caused by one reader closing the 
client, while another reader was still using it. 
{quote}I can be wrong but client sharing among the readers (memoization) looks 
like a premature optimization here and can be avoided at all, so every reader 
will use own client as usual. Am I wrong?
{quote}
I agree, sharing should just be removed here.
 

> SQS reader uses shared client instance without coordinating shutdown (AWS SDK 
> v2)
> ---------------------------------------------------------------------------------
>
>                 Key: BEAM-13509
>                 URL: https://issues.apache.org/jira/browse/BEAM-13509
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-aws
>            Reporter: Moritz Mack
>            Assignee: Moritz Mack
>            Priority: P2
>              Labels: SQS, aws-sdk-v2
>
> The SQS client may be shared across readers of the same source instance 
> without appropriate coordination when to close clients.
> This affects the direct runner, I'm not sure if other runners behave in a 
> similar way (cc [~aromanenko] ).
> Investigate if this is also an issue in SDK v1.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to