[
https://issues.apache.org/jira/browse/BEAM-13578?focusedWorklogId=702001&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-702001
]
ASF GitHub Bot logged work on BEAM-13578:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Dec/21 18:17
Start Date: 29/Dec/21 18:17
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #16372:
URL: https://github.com/apache/beam/pull/16372#discussion_r776441707
##########
File path: sdks/python/apache_beam/options/pipeline_options_validator.py
##########
@@ -365,3 +368,16 @@ def validate_environment_options(self, view):
self._validate_error(
self.ERR_INVALID_ENVIRONMENT, 'environment_config', 'LOOPBACK'))
return errors
+
+ def validate_repeatable_argument_passed_as_list(self, view, arg_name):
+ """Validates that repeatable PipelineOptions like dataflow_service_options
Review comment:
nit: comment wording. Suggestion:
```
Validates that repeatable PipelineOptions like dataflow_service_options
or experiments are specified as a list when set programmatically. This
way, users do not inadvertently specify them as a string, which triggers
incorrect implicit string -> list conversion.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 702001)
Time Spent: 20m (was: 10m)
> Enforce lists when specifying repeatable pipeline options programmatically
> --------------------------------------------------------------------------
>
> Key: BEAM-13578
> URL: https://issues.apache.org/jira/browse/BEAM-13578
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Andy Ye
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When users set a repeatable option as a string programmatically, for example:
> beam_options = PipelineOptions(experiments='use_runner_v2') , the value
> string is incorrectly converted into a list ['u', 's', 'e', ...]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
