[ 
https://issues.apache.org/jira/browse/BEAM-13308?focusedWorklogId=702257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-702257
 ]

ASF GitHub Bot logged work on BEAM-13308:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Dec/21 09:36
            Start Date: 30/Dec/21 09:36
    Worklog Time Spent: 10m 
      Work Description: AydarZaynutdinov commented on pull request #16384:
URL: https://github.com/apache/beam/pull/16384#issuecomment-1002946291


   > @AydarZaynutdinov I added almost all suggested changes. In the 
life_cycle.Setup method the `workingDir` is used without `pipelinesFolder` 
(line 64), so this method will still take 2 arguments(`workingDir`, 
`pipelinesFolder`). What do you think?
   
   I agree that we need here 2 arguments. So yes let's leave it as you did.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 702257)
    Time Spent: 1h  (was: 50m)

> [Playground] Getting baseFileFolder from environment
> ----------------------------------------------------
>
>                 Key: BEAM-13308
>                 URL: https://issues.apache.org/jira/browse/BEAM-13308
>             Project: Beam
>          Issue Type: Task
>          Components: beam-playground
>            Reporter: Pavel Avilov
>            Assignee: Pavel Avilov
>            Priority: P3
>              Labels: beam-playground-backend
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Need to get the baseFileFolder value from the environment variable (now 
> baseFileFolder is a constant). Also in the dockerfile for go SDK change the 
> command "go mod init executable_files" to "go mod init 
> ${PIPELINES_FOLDER_NAME}", where "PIPELINES_FOLDER_NAME" is the name of env. 
> variable  for baseFileFolder.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to