[
https://issues.apache.org/jira/browse/BEAM-6905?focusedWorklogId=219092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219092
]
ASF GitHub Bot logged work on BEAM-6905:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/19 03:43
Start Date: 27/Mar/19 03:43
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #8131:
[BEAM-6905] Add support for user distribution metrics.
URL: https://github.com/apache/beam/pull/8131#discussion_r269395054
##########
File path: model/pipeline/src/main/proto/metrics.proto
##########
@@ -204,6 +211,10 @@ message MonitoringInfoUrns {
TOTAL_MSECS = 5
[(org.apache.beam.model.pipeline.v1.beam_urn) =
"beam:metric:ptransform_execution_time:total_msecs:v1"];
+
+ USER_DISTRUBUTION_COUNTER_URN_PREFIX = 6
Review comment:
why are we distinguishing `USER_` things here? I am really not convinced
that there should be sharing between user and system-defined metrics in this
way.
System-defined metrics should be proto field _not_ enums or strings attached
to a generic metric mechanism.
User-defined metrics should be fairly opaque and a totally different
abstraction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 219092)
Time Spent: 3h 10m (was: 3h)
> Add support for User Distribution metrics for Python Streaming
> --------------------------------------------------------------
>
> Key: BEAM-6905
> URL: https://issues.apache.org/jira/browse/BEAM-6905
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow, sdk-py-harness
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> # Add new UserDistributionCounter urn to metrics.proto
> # Report UserDistribution metric in python SDK
> # Plumb User Distribution metric in Dataflow runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
