[
https://issues.apache.org/jira/browse/BEAM-6892?focusedWorklogId=219172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219172
]
ASF GitHub Bot logged work on BEAM-6892:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/19 06:43
Start Date: 27/Mar/19 06:43
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #8093: [BEAM-6892]
Schemas and destinations are provided to WriteToBigQuery separately
URL: https://github.com/apache/beam/pull/8093#discussion_r269422280
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -784,17 +798,18 @@ def __init__(self,
project (str): The ID of the project containing this table or
:data:`None` if the table reference is specified entirely by the table
argument.
- schema (str,dict,ValueProvider): The schema to be used if the
+ schema (str,dict,ValueProvider,callable): The schema to be used if the
BigQuery table to write has to be created. This can be either specified
as a :class:`~apache_beam.io.gcp.internal.clients.bigquery.\
bigquery_v2_messages.TableSchema`. or a `ValueProvider` that has a JSON string,
- or a python dictionary, or the string or dictionary itself.
+ or a python dictionary, or the string or dictionary itself,
object or a single string of the form
``'field1:type1,field2:type2,field3:type3'`` that defines a comma
separated list of fields. Here ``'type'`` should specify the BigQuery
type of the field. Single string based schemas do not support nested
fields, repeated fields, or specifying a BigQuery mode for fields
(mode will always be set to ``'NULLABLE'``).
+ If a callable, then it should return a str, dict or TableSchema.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 219172)
Time Spent: 3h 10m (was: 3h)
> Use temp_location for BQ FILE_LOADS on DirectRunner, and autocreate it in GCS
> if not specified by user.
> -------------------------------------------------------------------------------------------------------
>
> Key: BEAM-6892
> URL: https://issues.apache.org/jira/browse/BEAM-6892
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Pablo Estrada
> Priority: Major
> Fix For: 2.13.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)