[
https://issues.apache.org/jira/browse/BEAM-12391?focusedWorklogId=703504&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-703504
]
ASF GitHub Bot logged work on BEAM-12391:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/22 19:36
Start Date: 04/Jan/22 19:36
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16246:
URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16246](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7b5c4cd) into
[master](https://codecov.io/gh/apache/beam/commit/4471c1f95fbc381f0293589d8febb95d0e01f42d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(4471c1f) will **increase** coverage by `38.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16246 +/- ##
===========================================
+ Coverage 46.10% 84.11% +38.00%
===========================================
Files 196 450 +254
Lines 19498 65701 +46203
===========================================
+ Hits 8990 55264 +46274
- Misses 9538 10437 +899
+ Partials 970 0 -970
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/avroio.py](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXZyb2lvLnB5)
| `98.01% <100.00%> (ø)` | |
|
[sdks/go/pkg/beam/core/runtime/harness/sampler.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9zYW1wbGVyLmdv)
| | |
|
[sdks/go/pkg/beam/runners/dataflow/dataflow.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93Lmdv)
| | |
|
[sdks/go/pkg/beam/testing/passert/passert.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90ZXN0aW5nL3Bhc3NlcnQvcGFzc2VydC5nbw==)
| | |
|
[sdks/go/pkg/beam/beam.shims.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9iZWFtLnNoaW1zLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/pipelinex/replace.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvcGlwZWxpbmV4L3JlcGxhY2UuZ28=)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/panes.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3BhbmVzLmdv)
| | |
|
[sdks/go/pkg/beam/transforms/top/top.shims.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL3RvcC90b3Auc2hpbXMuZ28=)
| | |
|
[sdks/go/pkg/beam/xlang.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS94bGFuZy5nbw==)
| | |
|
[sdks/go/pkg/beam/metrics.go](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9tZXRyaWNzLmdv)
| | |
| ... and [637
more](https://codecov.io/gh/apache/beam/pull/16246/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[4471c1f...7b5c4cd](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 703504)
Time Spent: 3h 20m (was: 3h 10m)
> WriteToAvro fails if fastavro loads its python implementation of writer
> -----------------------------------------------------------------------
>
> Key: BEAM-12391
> URL: https://issues.apache.org/jira/browse/BEAM-12391
> Project: Beam
> Issue Type: Bug
> Components: io-py-avro
> Affects Versions: 2.25.0, 2.26.0, 2.27.0, 2.28.0, 2.29.0
> Reporter: Chris Chandler
> Assignee: John Casey
> Priority: P3
> Labels: starter
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> It's possible for fastavro to fail to correctly load its cython
> implementation of the Writer class in which case it will silently fall back
> to a pure python implementation. If this happens there's no outward
> indication, but line 621 in io/avroio.py will fail because writer.fo is only
> present on the cython implementation.
> To reproduce you can modify fastavro's write.py to only use its fallback:
> {code}
> #from . import _write
> from . import _write_py as _write
> {code}
> And then run a workflow that sinks to WriteToAvro(use_fastavro=True).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
