[
https://issues.apache.org/jira/browse/BEAM-13603?focusedWorklogId=704340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-704340
]
ASF GitHub Bot logged work on BEAM-13603:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/22 00:11
Start Date: 06/Jan/22 00:11
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16437:
URL: https://github.com/apache/beam/pull/16437#issuecomment-1006127975
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16437?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16437](https://codecov.io/gh/apache/beam/pull/16437?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e3d0bbc) into
[master](https://codecov.io/gh/apache/beam/commit/f51e1a6bfa0fb6e852f21734dfd0709dbf2b1b11?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f51e1a6) will **increase** coverage by `37.43%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/16437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16437 +/- ##
===========================================
+ Coverage 46.16% 83.59% +37.43%
===========================================
Files 197 452 +255
Lines 19523 61960 +42437
===========================================
+ Hits 9012 51797 +42785
- Misses 9540 10163 +623
+ Partials 971 0 -971
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/utils/shared.py](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmVkLnB5)
| `100.00% <100.00%> (ø)` | |
|
[sdks/go/pkg/beam/io/databaseio/writer.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9kYXRhYmFzZWlvL3dyaXRlci5nbw==)
| | |
|
[sdks/go/pkg/beam/encoding.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9lbmNvZGluZy5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/datasink.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9kYXRhc2luay5nbw==)
| | |
|
[sdks/go/pkg/beam/external.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9leHRlcm5hbC5nbw==)
| | |
|
[sdks/go/pkg/beam/core/util/hooks/hooks.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvaG9va3MvaG9va3MuZ28=)
| | |
|
[sdks/go/pkg/beam/transforms/stats/stats.shims.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL3N0YXRzL3N0YXRzLnNoaW1zLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/translate.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy90cmFuc2xhdGUuZ28=)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/discard.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9kaXNjYXJkLmdv)
| | |
|
[sdks/go/pkg/beam/core/graph/xlang.go](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL3hsYW5nLmdv)
| | |
| ... and [640
more](https://codecov.io/gh/apache/beam/pull/16437/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16437?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16437?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[f51e1a6...e3d0bbc](https://codecov.io/gh/apache/beam/pull/16437?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 704340)
Time Spent: 1h 10m (was: 1h)
> Shared object does not read from cache when using tag
> -----------------------------------------------------
>
> Key: BEAM-13603
> URL: https://issues.apache.org/jira/browse/BEAM-13603
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: ELVIS WIANDA
> Priority: P1
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code:java}
> cat shared_test.py{code}
>
> {code:java}
> import unittest
> from apache_beam.utils import shared
> class NamedObject(object):
> def __init__(self, name):
> self._name = name
> def get_name(self):
> return self._name
> class Sequence(object):
> def __init__(self):
> self._sequence = 0
> def make_acquire_fn(self):
> # Every time acquire_fn is called, increases the sequence number and
> returns
> # a NamedObject with that sequenece number.
> def acquire_fn():
> self._sequence += 1
> return NamedObject("sequence%d" % self._sequence)
> return acquire_fn
> class SharedTest(unittest.TestCase):
> def testDifferentObjects(self):
> sequence = Sequence()
> handle = shared.Shared()
> f1 = handle.acquire(sequence.make_acquire_fn(), tag="1")
> self.assertEqual("sequence1", f1.get_name())
> # should pass
> f1 = handle.acquire(sequence.make_acquire_fn(), tag="1")
> self.assertEqual("sequence1", f1.get_name())
> if __name__ == "__main__":
> unittest.main()
> {code}
> {code:java}
> python shared_test.py {code}
> {code:java}
> F
> ======================================================================
> FAIL: testDifferentObjects (__main__.SharedTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "shared_test.py", line 59, in testDifferentObjects
> self.assertEqual("sequence1", f1.get_name())
> AssertionError: 'sequence1' != 'sequence2'
> - sequence1
> ? ^
> + sequence2
> ? ^
>
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
