[
https://issues.apache.org/jira/browse/BEAM-6324?focusedWorklogId=219408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219408
]
ASF GitHub Bot logged work on BEAM-6324:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/19 16:15
Start Date: 27/Mar/19 16:15
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #8153: [BEAM-6324]
Remove withWhere from CassandraIO (superceded by withQuery)
URL: https://github.com/apache/beam/pull/8153#discussion_r269647525
##########
File path:
sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -305,26 +285,6 @@ public void testReadWithQuery() throws Exception {
pipeline.run();
}
- @Test
- public void testReadWithValueProvider() throws Exception {
Review comment:
This one was removed because the functionality is already covered by
delegation from the different with methods e.g. `withTable(String) ->
withTable(ValueProvider)`.
And we win some performance because of one less test that does not validate
anything new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 219408)
Time Spent: 12h (was: 11h 50m)
> CassandraIO.Read - Add the ability to provide a filter to the query
> -------------------------------------------------------------------
>
> Key: BEAM-6324
> URL: https://issues.apache.org/jira/browse/BEAM-6324
> Project: Beam
> Issue Type: Improvement
> Components: io-java-cassandra
> Affects Versions: 2.9.0
> Reporter: Shahar Frank
> Assignee: Shahar Frank
> Priority: Major
> Labels: performance, pull-request-available, triaged
> Fix For: 2.12.0
>
> Time Spent: 12h
> Remaining Estimate: 0h
>
> CassandraIO.Read doesn't support using WHERE to filter the input at the
> source (In Cassandra) which might provide great performance boost.
> Already implemented by:
> https://github.com/apache/beam/pull/7340
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
