[
https://issues.apache.org/jira/browse/BEAM-12562?focusedWorklogId=704779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-704779
]
ASF GitHub Bot logged work on BEAM-12562:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/22 20:48
Start Date: 06/Jan/22 20:48
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16256:
URL: https://github.com/apache/beam/pull/16256#discussion_r779855416
##########
File path: sdks/python/apache_beam/dataframe/frames_test.py
##########
@@ -1245,6 +1245,39 @@ def test_idxmax(self):
self._run_test(lambda s2: s2.idxmax(), s2)
self._run_test(lambda s2: s2.idxmax(skipna=False), s2)
+ def test_pipe(self):
+ def df_times(df, column, times):
+ df[column] = df[column] * times
+ return df
+
+ def df_times_shuffled(column, times, df):
+ return df_times(df, column, times)
+
+ def s_times(s, times):
+ return s * times
+
+ def s_times_shuffled(times, s):
+ return s_times(s, times)
+
+ df = pd.DataFrame({'A': [1, 2, 3], 'B': [4, 5, 6]}, index=[0, 1, 2])
+ s = pd.Series([1, 2, 3, 4, 5], index=[0, 1, 2, 3, 4])
+ # s2 = pd.Series([6, 7], index=[5, 6])
+
+ func_1 = df_times
+ func_2 = s_times
+ # func_3 = frames.DeferredSeries.append #pd.Series.append
+ func_4 = df_times_shuffled
+ func_5 = s_times_shuffled
+
+ self._run_inplace_test(lambda df: df.pipe(func_1, 'A', 2), df)
+ self._run_inplace_test(lambda df: df.pipe((func_4, 'df'), 'A', 2), df)
+
+ self._run_test(lambda s: s.pipe(func_2, 2), s)
+ self._run_test(lambda s: s.pipe((func_5, 's'), 2), s)
+
+ # self._run_test(lambda s, s2: s.append(s2).pipe(func_2, 2), s, s2)
+ # self._run_test(lambda s, s2: s.pipe(func_3, s2).pipe(func_2, 2), s, s2)
Review comment:
Yeah I think this is running into the issue that I expected the `.sum`
cases to run into. It's fine to remove these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 704779)
Time Spent: 6h 10m (was: 6h)
> Implement pipe for DataFrame, Series, and GroupBy
> -------------------------------------------------
>
> Key: BEAM-12562
> URL: https://issues.apache.org/jira/browse/BEAM-12562
> Project: Beam
> Issue Type: Improvement
> Components: dsl-dataframe
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P3
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Add an implementation of
> [pipe|https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.pipe.html]
> for DeferredDataFrame, DeferredSeries, and DeferredGroupBy. It should be
> fully unit tested with some combination of pandas_doctests_test.py and
> frames_test.py.
> https://github.com/apache/beam/pull/14274 is an example of a typical PR that
> adds new operations. See
> https://lists.apache.org/thread.html/r8ffe96d756054610dfdb4e849ffc6a741e826d15ba7e5bdeee1b4266%40%3Cdev.beam.apache.org%3E
> for background on the DataFrame API.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
