[
https://issues.apache.org/jira/browse/BEAM-11985?focusedWorklogId=704825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-704825
]
ASF GitHub Bot logged work on BEAM-11985:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/22 23:02
Start Date: 06/Jan/22 23:02
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #15562:
URL: https://github.com/apache/beam/pull/15562#issuecomment-1006998611
@rashidjeffreysky, @aaltay
The expected behavior is a single response (based on the [REST
API](https://cloud.google.com/bigtable/docs/reference/data/rpc/google.bigtable.v2#mutaterowsresponse))
with multiple `Status` entries. In the Python client implementation of
bigtable, the returned response is a `List[Optional[Status]]` (or equivalently
`List[Union[None, Status]]`)). Details: default
[value](https://github.com/googleapis/python-bigtable/blob/fec06fcd28c36d0d3b347b43d1f3d264e5f5aa39/google/cloud/bigtable/table.py#L1058)
is None, retryable errors will [return default
value](https://github.com/googleapis/python-bigtable/blob/fec06fcd28c36d0d3b347b43d1f3d264e5f5aa39/google/cloud/bigtable/table.py#L1078)
instead of a `Status` instance)
I'll send a PR to do the following 2 things:
1. Prevent the metrics gathering from failing the job;
2. Handle None cases and treat them as
['DEADLINE_EXCEEDED'](https://grpc.github.io/grpc/core/md_doc_statuscodes.html).
I fear that there is data-loss throughout the process. If a row mutation
fails but no error is raised, DF nor bigtable no longer retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 704825)
Time Spent: 9h 40m (was: 9.5h)
> Python Bigtable - Implement IO Request Count metrics
> ----------------------------------------------------
>
> Key: BEAM-11985
> URL: https://issues.apache.org/jira/browse/BEAM-11985
> Project: Beam
> Issue Type: Test
> Components: io-py-gcp
> Reporter: Alex Amato
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's
> needed to instrument this IO with Request Count metrics is found in this
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
