[
https://issues.apache.org/jira/browse/BEAM-13538?focusedWorklogId=704898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-704898
]
ASF GitHub Bot logged work on BEAM-13538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/22 04:51
Start Date: 07/Jan/22 04:51
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16348:
URL: https://github.com/apache/beam/pull/16348#issuecomment-1000491583
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16348?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16348](https://codecov.io/gh/apache/beam/pull/16348?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(07b7cd1) into
[master](https://codecov.io/gh/apache/beam/commit/4774ac713f427fefb38114f661516faef26d8207?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(4774ac7) will **increase** coverage by `9.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/16348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16348 +/- ##
==========================================
+ Coverage 74.67% 83.70% +9.02%
==========================================
Files 644 447 -197
Lines 81268 61745 -19523
==========================================
- Hits 60689 51685 -9004
+ Misses 19608 10060 -9548
+ Partials 971 0 -971
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/runtime/xlangx/namespace.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUveGxhbmd4L25hbWVzcGFjZS5nbw==)
| | |
|
[sdks/go/pkg/beam/core/util/symtab/symtab.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvc3ltdGFiL3N5bXRhYi5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/pcollection.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9wY29sbGVjdGlvbi5nbw==)
| | |
|
[...dks/go/pkg/beam/core/runtime/harness/monitoring.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9tb25pdG9yaW5nLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/coderx/varint.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvY29kZXJ4L3ZhcmludC5nbw==)
| | |
|
[sdks/go/pkg/beam/gbk.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9nYmsuZ28=)
| | |
|
[...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL2pvYi5nbw==)
| | |
|
[sdks/go/pkg/beam/impulse.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pbXB1bHNlLmdv)
| | |
|
[sdks/go/pkg/beam/runners/vet/vet.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3ZldC92ZXQuZ28=)
| | |
|
[sdks/go/pkg/beam/runners/direct/direct.go](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RpcmVjdC9kaXJlY3QuZ28=)
| | |
| ... and [192
more](https://codecov.io/gh/apache/beam/pull/16348/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16348?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16348?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[4774ac7...07b7cd1](https://codecov.io/gh/apache/beam/pull/16348?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 704898)
Time Spent: 1h 10m (was: 1h)
> :release:go-license doesn't get the correct version of container boot for
> licenses
> ----------------------------------------------------------------------------------
>
> Key: BEAM-13538
> URL: https://issues.apache.org/jira/browse/BEAM-13538
> Project: Beam
> Issue Type: Bug
> Components: release
> Reporter: Robert Burke
> Priority: P2
> Labels: bash, go, gradle
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Likely has been an issue throughout the lifetime of the code.
> At present the code is pulling the old pre-modules version of the code
> (2.32.0), so 2.33.0 through to present, haven't reflected licences to the go
> boot code. We need to check to see if those releases are missing licenses,
> but I think the risk there is small as the Go code used isn't large.
> The current fix would be to move things to be module aware and pull the v2
> (post module) paths with go-get.
> Our mitigation options in the short term are Be Eager (@master), or Be Stale
> (using @latest), which have the following implications. Being Stale means
> getting the code at the previous release, meaning the licences included *do
> not* include what's new since the last release. This is marginally better
> than present (locked at 2.32.0). Being Eager would mean getting what's at
> Beam Repo Head, which will include the release being built, but be at risk of
> diffs since the cut.
> The first PR is to stopgap into getting us to Be Eager which given the rate
> of change to the boot loaders, to be more accurate.
> The ideal would be to plumb the current release tag being built (or at least
> the short commit ID) so we can get the precise version of the code being
> built for licenses. This Jira is to track that fix.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
