[
https://issues.apache.org/jira/browse/BEAM-7386?focusedWorklogId=705208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705208
]
ASF GitHub Bot logged work on BEAM-7386:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/22 19:22
Start Date: 07/Jan/22 19:22
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #15275:
URL: https://github.com/apache/beam/pull/15275#issuecomment-1007674641
I need to take a look at the code, since it's changed a lot. However
elements don't arrive in timestamp order, so I'm not sure how you
would avoid this.
On Fri, Jan 7, 2022 at 10:35 AM laraschmidt ***@***.***>
wrote:
> I'm trying to page this back in. But if I remember correctly, the first
> element holds the watermark back until all not-late second elements would
> have appeared. So we don't actually need to hold it backwards. It's just
> the processElement that puts out older elements.
>
> Here's the relevant code for the timer which are not negative:
> if (elementAffectsWatermarkHolds) {
> addTimer(watermarkHolds,
> ts.plus(thisCollectionValidFor)).withOutputTimestamp(ts);
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15275#issuecomment-1007641545>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVOZTULKXCPAB2WT3VTUU4W7ZANCNFSM5BPZWL6Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
>
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
>
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 705208)
Time Spent: 18h 50m (was: 18h 40m)
> Add Utility BiTemporalStreamJoin
> --------------------------------
>
> Key: BEAM-7386
> URL: https://issues.apache.org/jira/browse/BEAM-7386
> Project: Beam
> Issue Type: Improvement
> Components: sdk-ideas
> Affects Versions: 2.12.0
> Reporter: Reza ardeshir rokni
> Assignee: Lara Schmidt
> Priority: P3
> Time Spent: 18h 50m
> Remaining Estimate: 0h
>
> Add utility class that enables a temporal join between two streams where
> Stream A is matched to Stream B where
> A.timestamp = (max(b.timestamp) where b.timestamp <= a.timestamp)
> This will use the following overall flow:
> KV(key, Timestamped<V>)
> | Window
> | GBK
> | Statefull DoFn
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
