[
https://issues.apache.org/jira/browse/BEAM-13386?focusedWorklogId=705240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705240
]
ASF GitHub Bot logged work on BEAM-13386:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/22 20:29
Start Date: 07/Jan/22 20:29
Worklog Time Spent: 10m
Work Description: ryanthompson591 commented on a change in pull request
#16250:
URL: https://github.com/apache/beam/pull/16250#discussion_r780511727
##########
File path: sdks/python/apache_beam/internal/cloudpickle_pickler.py
##########
@@ -99,6 +103,14 @@ def _create_absl_flags():
return flags.FLAGS
+def _pickle_rlock(obj):
+ return _create_rlock, tuple([])
+
+
+def _create_rlock():
+ return RLOCK_TYPE()
Review comment:
I actually looked at this a bit more. The reduce function can return a
(type, parameters) or (function, parameters)
I was using the (function, parameters) but upon experimentation I realized I
could simplify this by just using the type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 705240)
Time Spent: 4h (was: 3h 50m)
> Make cloudpickle the default pickle library
> -------------------------------------------
>
> Key: BEAM-13386
> URL: https://issues.apache.org/jira/browse/BEAM-13386
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Ryan Thompson
> Assignee: Ryan Thompson
> Priority: P3
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Make cloudpickle the default pickle library.
>
> See change [https://github.com/apache/beam/pull/15472] and docs
> [_https://s.apache.org/beam-picklers_].
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
