[
https://issues.apache.org/jira/browse/BEAM-13599?focusedWorklogId=705320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705320
]
ASF GitHub Bot logged work on BEAM-13599:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/22 23:41
Start Date: 07/Jan/22 23:41
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16433:
URL: https://github.com/apache/beam/pull/16433#issuecomment-1007705298
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16433](https://codecov.io/gh/apache/beam/pull/16433?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a94255b) into
[master](https://codecov.io/gh/apache/beam/commit/38b833aa1dd0685be9137f41f6071c55f0c50b46?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(38b833a) will **increase** coverage by `37.44%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a94255b differs from pull request most recent
head 37ffbb0. Consider uploading reports for the commit 37ffbb0 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/16433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16433 +/- ##
===========================================
+ Coverage 46.16% 83.60% +37.44%
===========================================
Files 197 452 +255
Lines 19523 61977 +42454
===========================================
+ Hits 9012 51816 +42804
- Misses 9540 10161 +621
+ Partials 971 0 -971
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...eam/io/gcp/datastore/v1new/rampup\_throttling\_fn.py](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9yYW1wdXBfdGhyb3R0bGluZ19mbi5weQ==)
| `95.45% <100.00%> (ø)` | |
|
[sdks/go/pkg/beam/option.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb24uZ28=)
| | |
|
[sdks/go/pkg/beam/core/runtime/xlangx/namespace.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUveGxhbmd4L25hbWVzcGFjZS5nbw==)
| | |
|
[sdks/go/pkg/beam/core/runtime/exec/encode.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9lbmNvZGUuZ28=)
| | |
|
[sdks/go/pkg/beam/core/metrics/store.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL21ldHJpY3Mvc3RvcmUuZ28=)
| | |
|
[sdks/go/pkg/beam/windowing.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS93aW5kb3dpbmcuZ28=)
| | |
|
[sdks/go/pkg/beam/transforms/filter/filter.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL2ZpbHRlci9maWx0ZXIuZ28=)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/row.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3Jvdy5nbw==)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/varint.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3ZhcmludC5nbw==)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/registry.go](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3JlZ2lzdHJ5Lmdv)
| | |
| ... and [640
more](https://codecov.io/gh/apache/beam/pull/16433/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16433?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16433?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[38b833a...37ffbb0](https://codecov.io/gh/apache/beam/pull/16433?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 705320)
Time Spent: 1.5h (was: 1h 20m)
> Overflow in Python Datastore RampupThrottlingFn
> -----------------------------------------------
>
> Key: BEAM-13599
> URL: https://issues.apache.org/jira/browse/BEAM-13599
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0
> Reporter: Daniel Thevessen
> Assignee: Daniel Thevessen
> Priority: P2
> Fix For: 2.36.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {code:java}
> File
> "/usr/local/lib/python3.8/site-packages/apache_beam/io/gcp/datastore/v1new/rampup_throttling_fn.py",
> line 74, in _calc_max_ops_budget
> max_ops_budget = int(self._BASE_BUDGET / self._num_workers * (1.5**growth))
> RuntimeError: OverflowError: (34, 'Numerical result out of range') `[while
> running 'Write to Datastore/Enforce throttling during ramp-up-ptransform-483']
> {code}
> An intermediate value is a float dependent on start time, meaning it can run
> into overflows in long-running pipelines (usually on the ~6th day).
> `max_ops_budget` should either clip to float(inf) or INT_MAX, or
> short-circuit the throttling decision [here|#L87] since it will long be
> irrelevant by then.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
