[
https://issues.apache.org/jira/browse/BEAM-13614?focusedWorklogId=706441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706441
]
ASF GitHub Bot logged work on BEAM-13614:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/22 20:16
Start Date: 10/Jan/22 20:16
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#16458:
URL: https://github.com/apache/beam/pull/16458#discussion_r781517475
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -1720,6 +1736,23 @@ public Object restriction() {
doFnInvoker.invokeOnTimer(timerId, timerFamilyId, onTimerContext);
}
+ private <K> void processOnWindowExpiration(Timer<K> timer) {
+ try {
+ currentKey = timer.getUserKey();
+ currentTimer = timer;
+ Iterator<BoundedWindow> windowIterator =
Review comment:
Ah yes, I see that you are mutating a field so that the nested instance
can carry it to the invoker. Gotta say there's quite a lot of implicit data
flows here. I understand it is mutation for efficiency. Might be worth thinking
about how to make them more explicit and local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 706441)
Time Spent: 7h 50m (was: 7h 40m)
> OnWindowExpiration is not supported for portable runners
> --------------------------------------------------------
>
> Key: BEAM-13614
> URL: https://issues.apache.org/jira/browse/BEAM-13614
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Luke Cwik
> Priority: P2
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> There is no representation for OnWindowExpiration in the portable model.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
