[
https://issues.apache.org/jira/browse/BEAM-6914?focusedWorklogId=219596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219596
]
ASF GitHub Bot logged work on BEAM-6914:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/19 20:36
Start Date: 27/Mar/19 20:36
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8143: [BEAM-6914]
Reverting behavior of Native BQ sink in Python
URL: https://github.com/apache/beam/pull/8143#discussion_r269758066
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -75,6 +75,15 @@ def default_encoder(obj):
"Object of type '%s' is not JSON serializable" % type(obj).__name__)
+def get_hashable_destination(destination):
Review comment:
https://github.com/apache/beam/pull/8076 adds a similar change to
bigquery_tools.py and has a docstring for this function, consider copying the
docstring from that PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 219596)
Time Spent: 1.5h (was: 1h 20m)
> Use BigQuerySink as default for 2.12.
> -------------------------------------
>
> Key: BEAM-6914
> URL: https://issues.apache.org/jira/browse/BEAM-6914
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Blocker
> Fix For: 2.12.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
