[
https://issues.apache.org/jira/browse/BEAM-13628?focusedWorklogId=707009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707009
]
ASF GitHub Bot logged work on BEAM-13628:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/22 17:24
Start Date: 11/Jan/22 17:24
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16483:
URL: https://github.com/apache/beam/pull/16483#issuecomment-1010118492
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16483](https://codecov.io/gh/apache/beam/pull/16483?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(c3d0097) into
[master](https://codecov.io/gh/apache/beam/commit/5201237142a27d52388f77116464e559224f67ca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5201237) will **increase** coverage by `0.01%`.
> The diff coverage is `90.90%`.
[](https://codecov.io/gh/apache/beam/pull/16483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16483 +/- ##
==========================================
+ Coverage 46.28% 46.30% +0.01%
==========================================
Files 201 201
Lines 19718 19725 +7
==========================================
+ Hits 9127 9134 +7
Misses 9610 9610
Partials 981 981
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...beam/core/runtime/harness/statecache/statecache.go](https://codecov.io/gh/apache/beam/pull/16483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9zdGF0ZWNhY2hlL3N0YXRlY2FjaGUuZ28=)
| `80.00% <90.90%> (+1.23%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16483?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16483?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[5201237...c3d0097](https://codecov.io/gh/apache/beam/pull/16483?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 707009)
Remaining Estimate: 0h
Time Spent: 10m
> [Go SDK] Make Side input cache fit resolved semantics.
> ------------------------------------------------------
>
> Key: BEAM-13628
> URL: https://issues.apache.org/jira/browse/BEAM-13628
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Affects Versions: 2.35.0
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P2
> Fix For: 2.36.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It's been determined the documentation in the proto was a a bit buggy WRT
> Side input semantics. Previous to https://github.com/apache/beam/pull/16474
> it said state cache tokens are globally unique, however, in implementation
> and the original design they are unique WRT their associated StateKeys.
> This means the Go SDK's side input cache is broken as delivered, and can
> cause a correctness issue when there are multiple distinct side inputs, of
> the same type. The mitigation is to not use the SideInput cache in affected
> versions (2.35.0). The cache is off by default.
> The correction will use the whole state key (which, for side inputs includes
> the transformID ,SideInputID) tuple (with a user key if it's a multimap side
> input)), along with the Runner provided token.
> Since this can at worst cause a data correctness issue rather than a pipeline
> failure, this should be part of the 2.36.0 release. We may wish to backport
> it to a 2.35.1 patch release, only for the Go SDK to close the gap as well.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
