[
https://issues.apache.org/jira/browse/BEAM-6502?focusedWorklogId=219599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219599
]
ASF GitHub Bot logged work on BEAM-6502:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/19 20:38
Start Date: 27/Mar/19 20:38
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #8146: [BEAM-6502]
Re-Remove runner time execution information from public API surface (now
including Watch)
URL: https://github.com/apache/beam/pull/8146#discussion_r269759040
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Watch.java
##########
@@ -228,6 +253,23 @@ Instant getWatermark() {
}
return res;
}
+
+ @Override
+ public boolean equals(Object o) {
Review comment:
These base class implementations (toString, equals, hashCode) look similar
to the default provided by AutoValue. Is there some important difference? If
it's subtle, perhaps mention it in a comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 219599)
Time Spent: 1h 20m (was: 1h 10m)
> SplittableDoFn: Re-Remove runner time execution information from public API
> surface
> -----------------------------------------------------------------------------------
>
> Key: BEAM-6502
> URL: https://issues.apache.org/jira/browse/BEAM-6502
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
> Labels: triaged
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Move the setting of "claim observers" within RestrictionTracker to another
> location to clean up the RestrictionTracker interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
