[
https://issues.apache.org/jira/browse/BEAM-13616?focusedWorklogId=707082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707082
]
ASF GitHub Bot logged work on BEAM-13616:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/22 19:24
Start Date: 11/Jan/22 19:24
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #16460:
URL: https://github.com/apache/beam/pull/16460#discussion_r782459996
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_43_2.groovy
##########
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.beam.gradle
+
+/**
+ * Utilities for working with our vendored version of gRPC.
+ *
+ * To update:
+ * 1. Determine the set of io.grpc libraries we want to include, most likely a
superset of
+ * of the previous vendored gRPC version.
+ * 2. Use mvn dependency:tree and https://search.maven.org/search?q=g:io.grpc
+ * to determine dependency tree. You may need to search for optional
dependencies
+ * and determine if they are needed (e.g. conscrypt).
+ * 3. Validate built artifacts by running linkage tool
+ *
(https://github.com/apache/beam/tree/master/vendor#how-to-validate-the-vendored-dependencies)
+ * and unit and integration tests in a PR (e.g. for
https://github.com/apache/beam/pull/16460,
Review comment:
```suggestion
* and unit and integration tests in a PR (e.g.
https://github.com/apache/beam/pull/16460,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 707082)
Time Spent: 4h 20m (was: 4h 10m)
> Update protobuf-java to 3.19.2 and other vendored dependencies that use
> protobuf
> --------------------------------------------------------------------------------
>
> Key: BEAM-13616
> URL: https://issues.apache.org/jira/browse/BEAM-13616
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Emily Ye
> Assignee: Emily Ye
> Priority: P1
> Fix For: 2.36.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> [https://github.com/protocolbuffers/protobuf/security/advisories/GHSA-wrvw-hg22-4m67]
> requires us to update versions of vendored artifacts that use protobuf, and
> recommended version of protobuf in BeamModuleGroovy
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
