[
https://issues.apache.org/jira/browse/BEAM-6841?focusedWorklogId=219705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219705
]
ASF GitHub Bot logged work on BEAM-6841:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/19 23:08
Start Date: 27/Mar/19 23:08
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #8061:
[BEAM-6841] Add support for reading query results using the BigQuery storage
API.
URL: https://github.com/apache/beam/pull/8061#discussion_r269804709
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOReadTest.java
##########
@@ -617,22 +614,17 @@ public void testEstimatedSizeWithStreamingBuffer()
throws Exception {
@Test
public void testBigQueryQuerySourceEstimatedSize() throws Exception {
- List<TableRow> data =
- ImmutableList.of(
- new TableRow().set("name", "A").set("number", 10L),
- new TableRow().set("name", "B").set("number", 11L),
Review comment:
Why did we have to significantly modify BigQueryIOReadTest (here and other
places) ? It's better if we can keep existing tests and add another set of
tests for storage API It's OK if this results in a little bit of code
duplication (any large duplications can be moved to utility classes). If this
PR significantly improves existing tests, please send that as a separate PR to
be submitted before submitting this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 219705)
Time Spent: 2h 50m (was: 2h 40m)
> Support reading query results with the BigQuery storage API
> -----------------------------------------------------------
>
> Key: BEAM-6841
> URL: https://issues.apache.org/jira/browse/BEAM-6841
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Kenneth Jung
> Assignee: Kenneth Jung
> Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
